Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide IO Types for MoleculeShapesModel schema #183

Closed
samreid opened this issue May 31, 2021 · 1 comment
Closed

Provide IO Types for MoleculeShapesModel schema #183

samreid opened this issue May 31, 2021 · 1 comment
Assignees

Comments

@samreid
Copy link
Member

samreid commented May 31, 2021

From https://github.com/phetsims/phet-io/issues/1774, we should create IO Types that can correctly capture the schema of the state objects.

    // TODO: Provide IO Types to specify these schemas instead of ObjectLiteralIO, see https://github.com/phetsims/phet-io/issues/1774
    // Shaped like this:
    // {
    //       position: Vector3.Vector3IO,
    //       velocity: Vector3.Vector3IO,
    //       isLonePair: BooleanIO,
    //       element: NullableIO( StringIO ),
    //       isCentralAtom: BooleanIO
    //     }
    groups: ArrayIO( ObjectLiteralIO ),

    // Shaped like this:
    //    {
    //     a: NumberIO,
    //     b: NumberIO,
    //     order: NumberIO,
    //     length: NumberIO
    //   }
    bonds: ArrayIO( ObjectLiteralIO ),
@jonathanolson
Copy link
Contributor

Handled above, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants