Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose or document Bond.dipoleProperty #72

Closed
zepumph opened this issue Jul 19, 2017 · 2 comments
Closed

Dispose or document Bond.dipoleProperty #72

zepumph opened this issue Jul 19, 2017 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jul 19, 2017

from code review #30
This DerivedProperty is never disposed, but it is also not documented that/why dispose is not needed like all other places in the repo.

@pixelzoom
Copy link
Contributor

From implementation-notes.md:

All objects created in this simulation exist for the lifetime of the simulation, so there is no need to call dispose.

But I added a comment:

    // @public dispose not needed, exists for the lifetime of the sim
    this.dipoleProperty = new DerivedProperty( [

@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017

Ok right, just making sure. Thanks for the comment.

@zepumph zepumph closed this as completed Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants