Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak? #71

Closed
zepumph opened this issue Jul 19, 2017 · 6 comments
Closed

Memory Leak? #71

zepumph opened this issue Jul 19, 2017 · 6 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jul 19, 2017

from code review #30

I fuzzMoused three separate times for over an hour each time the memory increased over 10MB. I don't know if that is large enough to warrant the title of "leak" but it wasn't tapering off, so I thought it warranted an issue to discuss.

The following showing a fuzzRate of 3000 for an hour (it starts at 50MB because I had a caching problem resolved in #70 ):

image

@pixelzoom
Copy link
Contributor

Heap comparison?

@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017

Still quite unsure about how to read them. I didn't find anything obvious that was mentioned during @jessegreenberg and my recent briefing by @jonathanolson. Would you mind calling to share screens for it. I think there is still a lot to learn about what to look for.

@pixelzoom
Copy link
Contributor

Would you mind calling to share screens for it. I think there is still a lot to learn about what to look for.

Unlikely before Monday.

@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017

Ok I'll see what I can do.

@zepumph
Copy link
Member Author

zepumph commented Jul 20, 2017

With a fuzzRate of 5000, I let it go for 2 hours, and here are the heap sizes.
image

It seems like it really tapered off at about 11MB. It took a long time to taper off, I'm not sure what that means. In the heap comparisons nothing really stood out to me. most deltas were in the Array and Object top level rows. Here is an example of a comparison.

image

@zepumph
Copy link
Member Author

zepumph commented Jul 20, 2017

After continuing that same tab this morning for multiple hours, I see that it did level off. Closing this issue, there isn't a memory leak.

image

@zepumph zepumph closed this as completed Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants