Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial memory almost twice what it was before the code review #70

Closed
zepumph opened this issue Jul 19, 2017 · 5 comments
Closed

Initial memory almost twice what it was before the code review #70

zepumph opened this issue Jul 19, 2017 · 5 comments
Assignees
@pixelzoom @zepumph
Labels
dev:code-review

Comments

@zepumph
Copy link
Member

zepumph commented Jul 19, 2017 •
edited
Loading

from code review #30
I would love confirmation, but I am seeing starting heap size now around 45-50MB, where as in #33 I saw that it was more like 25-30MB. Where did this come from? Is it acceptable?
@phet-steele
Copy link
Contributor

@zepumph http://www.colorado.edu/physics/phet/dev/html/molecule-polarity/1.0.0-dev.26/molecule-polarity_en.html started at 26 MB for me. Try a fresh browser tab?

@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017

Well that's good to know. I am still having trouble though:

image

@phet-steele
Copy link
Contributor

Go incognito?

@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017

I just did. All is well 23MB without RealMolecules and 27MB with. Closing

@zepumph zepumph closed this as completed Jul 19, 2017
@pixelzoom
Copy link
Contributor

Whew.

@zepumph zepumph mentioned this issue Jul 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

@zepumph zepumph

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixelzoom @phet-steele @zepumph