Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option: color scheme for electrostatic-potential surfaces #7

Closed
pixelzoom opened this issue Sep 4, 2014 · 4 comments
Closed

option: color scheme for electrostatic-potential surfaces #7

pixelzoom opened this issue Sep 4, 2014 · 4 comments
Assignees
@pixelzoom
Labels
dev:enhancement

Comments

@pixelzoom
Copy link
Contributor

When the new Options feature is implemented (phetsims/joist#154), add an option to switch the color scheme used for electrostatic-potential surfaces (red-white-&-blue vs rainbow).
@pixelzoom pixelzoom self-assigned this Sep 4, 2014
@pixelzoom
Copy link
Contributor Author

In the Java version, this option applied only to the 'Real Molecules' screen. The menu item was labeled "Real Molecules: use rainbow for electrostatic potential".

Should we make this apply to the 'Two Atoms' screen, too? Or did we do this because a rainbow gradient was too difficult to compute for the 'Two Atoms' screen?

pixelzoom added a commit that referenced this issue Oct 1, 2014
@pixelzoom
#7 add 'surfaceColor' query parameter for determining the color schem…
5fba28f 
…e used for electrostatic-potential in 'Real Molecules' screen
@pixelzoom
Copy link
Contributor Author

In preparation for having an Options dialog, I added 'surfaceColor' query parameter, which can have values 'RWB' (red-white-blue) or 'ROYGB' (rainbow).

@pixelzoom pixelzoom changed the title add option to switch color scheme used for electrostatic-potential surfaces option: color scheme for electrostatic-potential surfaces Nov 2, 2014
pixelzoom added a commit that referenced this issue Jan 15, 2015
@pixelzoom
#5, #7 add properties and user interface for global options (properti…
756f453 
…es are not wired up yet)
@pixelzoom pixelzoom mentioned this issue Jan 15, 2015
Closed
pixelzoom added a commit that referenced this issue Jan 15, 2015
@pixelzoom
#7 wire up MPGlobalOptions.surfaceColor to color key in 'Real Molecul…
d11b93c 
…es' screen
@pixelzoom
Copy link
Contributor Author

All work on this feature is completed. Resolution of phetsims/chipper#81 is a prerequisite for closing this issue.

@pixelzoom
Copy link
Contributor Author

Closing this issue. Tracking the key-collision issue in #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom