Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Properties that are booleans to BooleanProperties? #63

Closed
zepumph opened this issue Jul 18, 2017 · 5 comments
Closed

Convert Properties that are booleans to BooleanProperties? #63

zepumph opened this issue Jul 18, 2017 · 5 comments
Assignees
@pixelzoom @zepumph
Labels
status:ready-for-review type:question

Comments

@zepumph
Copy link
Member

zepumph commented Jul 18, 2017 •
edited
Loading

from code review #30
I'm sure I see the added value of this, but maybe you do. I know it helps when it comes to PhET-iO instrumentation, but only a bit, and that is far down the road. Your call.
@pixelzoom
Copy link
Contributor

FYI... When this sim was written (2014) there was no BooleanProperty, or any other type-specific Properties.

pixelzoom added a commit that referenced this issue Jul 19, 2017
@pixelzoom
use BooleanProperty #63
3f7a121
@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 19, 2017 •
edited
Loading

Done, @zepumph please review.

BooleanProperty is used for all of the check boxes, and the E-field on/off switch.

@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017

FYI... When this sim was written (2014) there was no BooleanProperty, or any other type-specific Properties.

Ahhh makes sense, thanks for informing. All looks good here. Closing

@zepumph zepumph closed this as completed Jul 19, 2017
@zepumph
Copy link
Member Author

zepumph commented Jul 19, 2017 •
edited
Loading

BooleanProperty is used for all of the check boxes, and the E-field on/off switch.

Is this directed at me as a "when you are developing this is what phet does" or more of a "this is how it is implemented in this sim for the world to know"?

@pixelzoom
Copy link
Contributor

Just an FYI about where the BooleanProperties are used, in case you wanted to check to see if I missed any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

@zepumph zepumph

Labels
status:ready-for-review type:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph