Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TranslateArrowsNode should be in common/ #49

Closed
zepumph opened this issue Jul 14, 2017 · 1 comment
Closed

TranslateArrowsNode should be in common/ #49

zepumph opened this issue Jul 14, 2017 · 1 comment
Assignees
@pixelzoom
Labels
dev:code-review

Comments

@zepumph
Copy link
Member

zepumph commented Jul 14, 2017 •
edited
Loading

From code review #30
I see this import line in twoatoms/view/DiatomicMoleculeNode.js:
var TranslateArrowsNode = require( 'MOLECULE_POLARITY/threeatoms/view/TranslateArrowsNode' );

This type should be factored out to common.
pixelzoom added a commit that referenced this issue Jul 14, 2017
@pixelzoom
move TranslateArrowsNode to common/view/ #49
73fc29b
@pixelzoom
Copy link
Contributor

Good catch. TranslateArrowsNode was originally used only in "Three Atoms", but decisions in #35 add it to "Two Atoms" too. I've moved it to common. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph