Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify visibility annotation in DiatomicMoleculeNode #48

Closed
zepumph opened this issue Jul 14, 2017 · 1 comment
Closed

Clarify visibility annotation in DiatomicMoleculeNode #48

zepumph opened this issue Jul 14, 2017 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented Jul 14, 2017

from code review #30
I'm confused about this comment before a batch of node declarations:

// @private nodes whose visibility may change
this.partialChargeNodeA = PartialChargeNode.createOppositePartialChargeNode( molecule.atomA, molecule.bond ); // @private
    this.partialChargeNodeB = PartialChargeNode.createOppositePartialChargeNode( molecule.atomB, molecule.bond ); // @private
    this.electrostaticPotentialNode = new ElectrostaticPotentialNode( molecule ); // @private
    this.electronDensityNode = new ElectronDensityNode( molecule ); // @private
    this.bondDipoleNode = new BondDipoleNode( molecule.bond ); // @private

Could you be a bit more specific. I didn't realize visibility annotations could change throughout the lifetime of a sim. If I'm just ignorant please inform and sorry to both with another issue.

@pixelzoom
Copy link
Contributor

You're confusing visibility of Nodes (whether they are rendered) with visibility annotations.

I've removed the confusing comment. @zepumph please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants