Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Bond/MoleculeAngleHandler to *AngleDragHandler? #45

Closed
zepumph opened this issue Jul 13, 2017 · 3 comments
Closed

Rename Bond/MoleculeAngleHandler to *AngleDragHandler? #45

zepumph opened this issue Jul 13, 2017 · 3 comments
Assignees
@pixelzoom @zepumph
Labels
dev:code-review status:ready-for-review type:question

Comments

@zepumph
Copy link
Member

zepumph commented Jul 13, 2017

From code review #30.

This may be a bit clearer with what the type is doing. It also seems idiomatic with other subtypes of SimpleDragHandler.

I defer to your judgment @pixelzoom.
@pixelzoom
Copy link
Contributor

That sounds reasonable, will do.

pixelzoom added a commit that referenced this issue Jul 13, 2017
@pixelzoom
rename drag handlers, #45
1545d67
@pixelzoom
Copy link
Contributor

Changes push. @zepumph please verify.

@zepumph
Copy link
Member Author

zepumph commented Jul 13, 2017

Looks good, thanks.

@zepumph zepumph closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

@zepumph zepumph

Labels
dev:code-review status:ready-for-review type:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph