Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should jsMole dir be in .gitignore? #44

Closed
zepumph opened this issue Jul 12, 2017 · 1 comment
Closed

Should jsMole dir be in .gitignore? #44

zepumph opened this issue Jul 12, 2017 · 1 comment
Assignees
@pixelzoom
Labels
dev:code-review type:question

Comments

@zepumph
Copy link
Member

zepumph commented Jul 12, 2017

From code review #30

Does .gitignore match the one in simula-rasa?

I see a dir for jsmole, should that remain? I read through #15 and #22 and found that perhaps that is being phased out. @pixelzoom I'll let you decide and fix if needed.
pixelzoom added a commit that referenced this issue Jul 13, 2017
@pixelzoom
remove jsmol-14.2.4 from .gitignore, #44
290cbde
@pixelzoom
Copy link
Contributor

The entry for jsmol-14.2.4 in .gitignore is indeed vestigial, left over from when we were pursuing JSmol as a solution for the 3D molecule viewer. I've removed it in the above commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:code-review type:question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @zepumph