Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Real Molecules dialog always stay within screen bounds? #42

Closed
zepumph opened this issue Jul 11, 2017 · 2 comments
Closed

Should Real Molecules dialog always stay within screen bounds? #42

zepumph opened this issue Jul 11, 2017 · 2 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jul 11, 2017

From code review #30

I noticed on stringTest=xss and confirmed with

http://localhost/molecule-polarity/molecule-polarity_en.html?brand=phet&ea&stringTest=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

If the string is long enough, then the dialog on the Real Molecules screen gets to be too wide for the screen. I'm not sure if we support this, but it seems like translators could have a sentence that is this big (although unlikely). I'm not sure if we normally support a "wrap" of text that is too long. Sounds like a pain in the but. Maybe it is just up to our translators to use a sentence of the same length as ours.

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 12, 2017

Fixed in master. Tested with ?dev&stringTest=xss, see screenshot below. @zepumph please verify.

screenshot_52

@zepumph
Copy link
Member Author

zepumph commented Jul 13, 2017

Looks great, thanks for the speedy turnaround. Closing

@zepumph zepumph closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants