Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credits #28

Closed
pixelzoom opened this issue Jun 28, 2017 · 7 comments
Closed

credits #28

pixelzoom opened this issue Jun 28, 2017 · 7 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Finalize credits in molecule-polarity-main.js.

When RC testing is completed, any credit updates should be done in both the 1.0 and master branches.

pixelzoom added a commit that referenced this issue Jul 10, 2017
@pixelzoom
Copy link
Contributor Author

@emily-phet please let me know if anyone else needs to be added to the credits. (QA credits will be completed by @phet-steele after RC testing). Here are the current credits, copied from the Java version:

screenshot_303

@pixelzoom pixelzoom reopened this Jul 10, 2017
@pixelzoom
Copy link
Contributor Author

Whoopsie, I pressed the close button. Reopening.

@emily-phet
Copy link

@pixelzoom Looks good to me. Let's go with this.

@kathy-phet
Copy link

And add QA team when they know who will test. :)

This was referenced Jul 12, 2017
@pixelzoom
Copy link
Contributor Author

Now in RC testing (phetsims/qa#28), so assigning this issue to @phet-steele.

@phet-steele
Copy link
Contributor

@pixelzoom, please add:

Steele Dalton, Alex Dornan, Ethan Johnson

pixelzoom added a commit that referenced this issue Jul 26, 2017
pixelzoom added a commit that referenced this issue Jul 26, 2017
@pixelzoom
Copy link
Contributor Author

QA credits have been added to master and 1.0 branches. Final credits shown below. Closing.

screenshot_332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants