Skip to content

Commit

Permalink
TODOs for #144
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Aug 31, 2022
1 parent a05c5a9 commit 3e7cb46
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions js/common/view/DipoleDirectionRadioButtonGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class DipoleDirectionRadioButtonGroup extends AquaRadioButtonGroup {
}, MPConstants.AQUA_RADIO_BUTTON_OPTIONS, options );

// d+ -> d-
//TODO https://github.com/phetsims/molecule-polarity/issues/140 not showing up in Studio, maybe because dialog is in a PhetioCapsule?
//TODO https://github.com/phetsims/molecule-polarity/issues/144 not showing up in Studio
const positiveToNegativeStringProperty = new DerivedProperty( [
moleculePolarityStrings.pattern.dipoleDirectionStringProperty,
moleculePolarityStrings.deltaPlusStringProperty,
Expand All @@ -57,7 +57,7 @@ class DipoleDirectionRadioButtonGroup extends AquaRadioButtonGroup {
} ) );

// d- -> d+
//TODO https://github.com/phetsims/molecule-polarity/issues/140 not showing up in Studio, maybe because dialog is in a PhetioCapsule?
//TODO https://github.com/phetsims/molecule-polarity/issues/144 not showing up in Studio
const negativeToPositiveStringProperty = new DerivedProperty( [
moleculePolarityStrings.pattern.dipoleDirectionStringProperty,
moleculePolarityStrings.deltaPlusStringProperty,
Expand All @@ -77,13 +77,17 @@ class DipoleDirectionRadioButtonGroup extends AquaRadioButtonGroup {
const radioButtonGroupItems = [
{
value: DipoleDirection.POSITIVE_TO_NEGATIVE,

//TODO //TODO https://github.com/phetsims/molecule-polarity/issues/144 no textProperty linked element in Studio
node: new Text( positiveToNegativeStringProperty, merge( {
tandem: options.tandem.createTandem( positiveToNegativeRadioButtonTandemName ).createTandem( 'labelText' )
}, TEXT_OPTIONS ) ),
tandemName: positiveToNegativeRadioButtonTandemName
},
{
value: DipoleDirection.NEGATIVE_TO_POSITIVE,

//TODO //TODO https://github.com/phetsims/molecule-polarity/issues/144 no textProperty linked element in Studio
node: new Text( negativeToPositiveStringProperty, merge( {
tandem: options.tandem.createTandem( negativeToPositiveRadioButtonTandem ).createTandem( 'labelText' )
}, TEXT_OPTIONS ) ),
Expand Down

0 comments on commit 3e7cb46

Please sign in to comment.