Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename particlesGroupTandem to particlesGroup #36

Closed
pixelzoom opened this issue Jun 19, 2017 · 3 comments
Closed

rename particlesGroupTandem to particlesGroup #36

pixelzoom opened this issue Jun 19, 2017 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Related to dev test phetsims/tasks#821.

Skype:
[6/19/17, 12:40:56 PM] Steele Dalton: any reason you named it “particlesGroupTandem” instead of just “particlesGroup”? They show up in the Instance Proxies as “Particle Group Tandem_#”, but I would think it would look cleaner as “Particle Group_#”. Not sure I’ve seen the word “Tandem” in a tandem ID before.
[6/19/17, 12:44:37 PM] Chris Malley: no idea why it's named that. i recall collaborating on "group tandem" with SR. looking at other uses of createGroupTandem, I agree, should be called "particlesGroup".

@pixelzoom
Copy link
Contributor Author

Done. @phet-steele please verify in master.

@pixelzoom
Copy link
Contributor Author

FYI, here's what I see with instance-proxies wrapper:

Particles Group_0
molarity.molarityScreen.view.precipitateNode.particlesGroup_0: TNode

Particles Group_1
molarity.molarityScreen.view.precipitateNode.particlesGroup_1: TNode

...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants