Sounds no longer occur during keyboard input

[jbphet]

While working on phetsims/sun#697 I noticed that this sim no longer produces sound on every keyboard-nav-driven change of the slider values. The live version does do this (version 1.5.6). This may be related to recent work done on slider sound, or may be due to something else. Regardless, it should be investigated and fixed.

[jbphet]

After a little research, I think this problem arose due to changes made in common code under phetsims/scenery#997, where the pointer type a11y was changed to pdom. I've changed the code in the Molarity sim to check for the pdom pointer type (see the commit linked above), but I'd like to get a quick thumbs up or down from the person who made the common-code change. The reason I'm a little concerned is that I saw code that looked like the snippet below in scenery.js, and I want to make sure that I'm safe only looking for the pdom value, and don't need to also check for a11y.

  if ( name === 'a11y' || name === 'pdom' ) {

Assigning to @zepumph for what I think should be a very quick review. Feel free to close if this if it looks good.

[zepumph]

Very nice! Thanks for that, I must have missed it during my rename to PDOMPointer. Thank you. I found another one too, and created phetsims/scenery#1401 to improve type checking for this. Ready to close?

[zepumph]

Thanks for this, I missed these when I converted A11yPointer to PDOMPointer. I also found one more usage and made phetsims/scenery#1401 to help us in the future. Thanks!