Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a11y strings to en json strings file #205

Closed
zepumph opened this issue Dec 30, 2019 · 5 comments
Closed

Move a11y strings to en json strings file #205

zepumph opened this issue Dec 30, 2019 · 5 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Dec 30, 2019

This is the next step in the a11y string conversion process. previous issues include phetsims/rosetta#214 and phetsims/chipper#795

This is the first simulation that we are doing with this, and so I will work closely with @jbphet to make sure that everything works well. Since molarity is already in RC, my hope is to do this conversion in one commit on master, and then be able to cherry-pick it easily over to the rc branch.

@zepumph
Copy link
Member Author

zepumph commented Dec 30, 2019

This was done in two commits above. There were a couple of assertions that needed to be fixed before committing this. I also spent a bit of time reorganizing the structure to try to encapsulate the comments, and then I removed the comments. I will now cherry-pick these into the rc branch.

@zepumph
Copy link
Member Author

zepumph commented Dec 30, 2019

After discussing with @jbphet, we are going to create another rc immediately so that @jbphet can test this with a local copy of rosetta before publication.

zepumph added a commit that referenced this issue Dec 30, 2019
zepumph added a commit that referenced this issue Dec 30, 2019
zepumph added a commit that referenced this issue Dec 30, 2019
@zepumph
Copy link
Member Author

zepumph commented Dec 30, 2019

Alright @jbphet, the a11y strings have been integrated into the json strings file in https://phet-dev.colorado.edu/html/molarity/1.5.0-rc.2/phet/. Please test this and let me know if you run into any problems with how rosetta ignores the a11y strings.

@jbphet
Copy link
Contributor

jbphet commented Dec 31, 2019

Test complete, everything looks good. As far as Rosetta is concerned, you should be good to publish this sim @zepumph.

For the record, here is a summary of how this testing was done:

  • Tested using a version of Rosetta that was running on my local machine, SHA = 539f81e1b30d9d68f9e819de9bc986f769a90985, which is close to what is currently live on the public website but probably a couple of minor commits ahead.
  • The code in simData.getLiveSimUrl was modified to use the RC link above as the English version of the sim from which the string keys are extracted when Molarity is the selected sim (this was obviously not committed).
  • Pointed Chrome to the locally running translation utility (http://localhost:16372/translate/ in my case), selected Molarity as the sim and Abkhazian (ab) as the locale. Verified that none of the a11y strings appeared on the UI and that the output log contained entries about a11y strings being found in the sim but explicitly skipped.
  • Changed a couple of strings, verified that the "Test" feature worked.
  • Submitted the changed strings using the "Submit" button (Rosetta is configured to use the "tests" branch of babel when running on my machine), verified that the commit looked correct (commit: phetsims/babel@67467a3).

Back to you @zepumph.

@jbphet jbphet assigned zepumph and unassigned jbphet Dec 31, 2019
@zepumph
Copy link
Member Author

zepumph commented Jan 6, 2020

This has been complete, and once this sim is published, we will note in phetsims/rosetta#214 for final testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants