-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move a11y strings to en json strings file #205
Comments
This was done in two commits above. There were a couple of assertions that needed to be fixed before committing this. I also spent a bit of time reorganizing the structure to try to encapsulate the comments, and then I removed the comments. I will now cherry-pick these into the rc branch. |
Alright @jbphet, the a11y strings have been integrated into the |
Test complete, everything looks good. As far as Rosetta is concerned, you should be good to publish this sim @zepumph. For the record, here is a summary of how this testing was done:
Back to you @zepumph. |
This has been complete, and once this sim is published, we will note in phetsims/rosetta#214 for final testing. |
This is the next step in the a11y string conversion process. previous issues include phetsims/rosetta#214 and phetsims/chipper#795
This is the first simulation that we are doing with this, and so I will work closely with @jbphet to make sure that everything works well. Since molarity is already in RC, my hope is to do this conversion in one commit on master, and then be able to cherry-pick it easily over to the rc branch.
The text was updated successfully, but these errors were encountered: