Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic locale #39

Closed
3 tasks done
pixelzoom opened this issue Sep 13, 2022 · 2 comments
Closed
3 tasks done

Add support for dynamic locale #39

pixelzoom opened this issue Sep 13, 2022 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 13, 2022

  • use Property instead of string for translated strings
  • add "supportsDynamicLocale": true to package.json and run grunt modulify
  • address dynamic layout problems
@pixelzoom pixelzoom self-assigned this Sep 13, 2022
pixelzoom added a commit that referenced this issue Sep 13, 2022
pixelzoom added a commit that referenced this issue Sep 13, 2022
pixelzoom added a commit that referenced this issue Sep 13, 2022
pixelzoom added a commit that referenced this issue Sep 13, 2022
pixelzoom added a commit that referenced this issue Sep 13, 2022
@pixelzoom
Copy link
Contributor Author

I've done the first parts of this. But I'm blocked on addressing layout issues until I can identify those issues, which requires phetsims/chipper#1319 to be addressed. So I'll come back to this.

@pixelzoom
Copy link
Contributor Author

I tested this sim with ?stringTest=dynamic and corrected a few minor issues in the above commits. It is otherwise well-behaved. Since new development is supposed to support dynamic layout, I see no reason to keep this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant