-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presentation of Electron Energy Level diagram #33
Comments
7/14/2022 design meeting: I mentioned that I prefer the layout of the original Java sim. The new layout has a lot of problems, and we can't fit everything in. |
Unassigning myself until work resumes on this sim. |
Today design meeting
|
Electron Energy Level diagrams are implemented and ready for pixel polishing. They currently look and behave exactly like the Java version. Things that I don't like about this presentation:
Note that #64 also reported problems with the arrows. I'm going to close that issue, and we'll use this as the issue for pixel polishing going foward. Over to @DianaTavares for review and next steps. I'm guessing that this will require a design meeting. |
For discussion....
|
We can certainly discuss changing that... But it is actually a feature in the Java version, which I've also implemented in the HTML5 version. A transition line is shown for a maximum of 1.5 seconds before it is hidden.
No, that's not possible n = 4, 5, 6 -- there is not enough space between those level lines to include both a squiggle and arrow head above the electron. I don't think we should have a solution that works only some of the time. |
Oh, I see. Even when paused, the transition line disappears. Yes, that is a bug -- fix coming up! |
Nice!
True... now I think that something that works for everything is the straight line. But I like the squiggle, well we need a design meeting anyway, so let's wait to see what the team proposes, but I will think about it as well. |
Related to #1 design refresh...
In the Java version, the Electron Energy Level diagram was in an accordion box that covered the Legend. It was a very odd UI. When collapsed it was a checkbox:
When expanded, it was an accordion box:
The Electron Energy Level diagram is relevant only in the 2nd (Energy Levels) screen of the HTML version. The HTML5 design doc shows this UI (collapsed and expanded):
But there's a major problem here. These mockups are using screen realestate that we simply do not have. Here's what the current HTML5 implementation looks like:
There's no way that we can squeeze a major accordion box in here without compromising usability.
Assigning to @arouinfar for design.
The text was updated successfully, but these errors were encountered: