Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation of Electron Energy Level diagram #33

Open
pixelzoom opened this issue Jul 5, 2022 · 9 comments
Open

Presentation of Electron Energy Level diagram #33

pixelzoom opened this issue Jul 5, 2022 · 9 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 5, 2022

Related to #1 design refresh...

In the Java version, the Electron Energy Level diagram was in an accordion box that covered the Legend. It was a very odd UI. When collapsed it was a checkbox:

screenshot_1747

When expanded, it was an accordion box:

screenshot_1743

The Electron Energy Level diagram is relevant only in the 2nd (Energy Levels) screen of the HTML version. The HTML5 design doc shows this UI (collapsed and expanded):

screenshot_1748

screenshot_1749

But there's a major problem here. These mockups are using screen realestate that we simply do not have. Here's what the current HTML5 implementation looks like:

screenshot_1750

There's no way that we can squeeze a major accordion box in here without compromising usability.

Assigning to @arouinfar for design.

@pixelzoom pixelzoom changed the title Presentation of Electron Energy Level Presentation of Electron Energy Level diagram Jul 5, 2022
@pixelzoom pixelzoom mentioned this issue Jul 5, 2022
@pixelzoom
Copy link
Contributor Author

7/14/2022 design meeting:

I mentioned that I prefer the layout of the original Java sim. The new layout has a lot of problems, and we can't fit everything in.

@arouinfar
Copy link

Unassigning myself until work resumes on this sim.

@DianaTavares
Copy link
Contributor

Today design meeting

CM needs to build that screen to see how much real estate we actually have.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Dec 17, 2024

Electron Energy Level diagrams are implemented and ready for pixel polishing. They currently look and behave exactly like the Java version.

Things that I don't like about this presentation:

  • It's very problematic to display an arrow head. When transitioning to a lower state, the arrow head is behind the electron, because the electron sits on top of the energy-level line. And for states that are close together, we are omitting the arrow head because there's no space to draw one. So the arrow head looks awful, and it appears inconsistently. I would remove the arrow head, since the electron serves the same purpose -- showing you the transition direction.

  • I don't like the squiggle line. It's intended to convey information about wavelength via the period of the squiggle. I think that's way too subtle, displayed periods are not different enough to be informative, and the squiggle results in a noisy display. A straight line (as is typically used on these diagrams) would be more effective.

Note that #64 also reported problems with the arrows. I'm going to close that issue, and we'll use this as the issue for pixel polishing going foward.

Over to @DianaTavares for review and next steps. I'm guessing that this will require a design meeting.

@pixelzoom
Copy link
Contributor Author

For discussion....

  • 1.0.0-dev.15 is the same as the Java version - squiggle with arrow head.

  • 1.0.0-dev.16 has a squiggle, but no arrow head.

  • 1.0.0-dev.17 uses a straight line (no squiggle, no arrow head), made slightly thicker (lineWidth: 2) so that the wavelength color is more prominent.

@DianaTavares
Copy link
Contributor

I also think a design meeting is needed. I guess it needs to wait until January. These are my ideas:

  1. The transition arrow/line disappears when the sim is paused and I think it is an error: I play with the sim and try to take screenshots of the transition in the Electron Energy Level Diagram, then, when it happens, I pause the simulation, but after a short time the line/arrow disappears!

  2. looks like, the arrow and the squiggle, are drawn for the bottom do the electron, and they look overlapped going down. Is it possible that the arrow/squiggle line is drawn, not to the line of the level, but to the edge of the electron? Something like this:
    image

My preference is the squiggle line (dev.16)

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Dec 17, 2024

  1. The transition arrow/line disappears when the sim is paused and I think it is an error: I play with the sim and try to take screenshots of the transition in the Electron Energy Level Diagram, then, when it happens, I pause the simulation, but after a short time the line/arrow disappears!

We can certainly discuss changing that... But it is actually a feature in the Java version, which I've also implemented in the HTML5 version. A transition line is shown for a maximum of 1.5 seconds before it is hidden.

  1. looks like, the arrow and the squiggle, are drawn for the bottom do the electron, and they look overlapped going down. Is it possible that the arrow/squiggle line is drawn, not to the line of the level, but to the edge of the electron? Something like this:

No, that's not possible n = 4, 5, 6 -- there is not enough space between those level lines to include both a squiggle and arrow head above the electron. I don't think we should have a solution that works only some of the time.

@pixelzoom
Copy link
Contributor Author

... I pause the simulation, but after a short time the line/arrow disappears!

Oh, I see. Even when paused, the transition line disappears. Yes, that is a bug -- fix coming up!

@DianaTavares
Copy link
Contributor

Oh, I see. Even when paused, the transition line disappears. Yes, that is a bug -- fix coming up!

Nice!

No, that's not possible n = 4, 5, 6 -- there is not enough space between those level lines to include both a squiggle and arrow head above the electron. I don't think we should have a solution that works only some of the time

True... now I think that something that works for everything is the straight line. But I like the squiggle, well we need a design meeting anyway, so let's wait to see what the team proposes, but I will think about it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants