Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with PipeModel Tandem.REQUIRED option? #80

Closed
samreid opened this issue Jul 1, 2022 · 1 comment
Closed

How to deal with PipeModel Tandem.REQUIRED option? #80

samreid opened this issue Jul 1, 2022 · 1 comment

Comments

@samreid
Copy link
Member

samreid commented Jul 1, 2022

In #78 @marlitas and I observed this review comment:

  public constructor( providedOptions?: PipeModelOptions ) {
    const options = optionize<PipeModelOptions, SelfOptions, PhetioObjectOptions>()( {
      isOpen: false,
      phetioType: PipeModel.PipeModelIO,
      //REVIEW replace with PickRequired<PhetioObjectOptions, 'tandem'>
      tandem: Tandem.REQUIRED,
      phetioDynamicElement: true
    }, providedOptions );

This issue requires further discussion, so we are promoting that REVIEW comment to this issue.

We would like to add PickRequired<PhetioObjectOptions, 'tandem'> to the options, but we don't want to remove tandem: Tandem.REQUIRED until phetsims/tandem#253 has been completed.

@marlitas
Copy link
Contributor

phetsims/tandem#253 has been closed, and this issue has been dealt with accordingly, by removing Tandem.REQUIRED and replacing with a PickRequired. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants