You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #78@marlitas and I observed this review comment:
publicconstructor(providedOptions?: PipeModelOptions){constoptions=optionize<PipeModelOptions,SelfOptions,PhetioObjectOptions>()({isOpen: false,phetioType: PipeModel.PipeModelIO,//REVIEW replace with PickRequired<PhetioObjectOptions, 'tandem'>tandem: Tandem.REQUIRED,phetioDynamicElement: true},providedOptions);
This issue requires further discussion, so we are promoting that REVIEW comment to this issue.
We would like to add PickRequired<PhetioObjectOptions, 'tandem'> to the options, but we don't want to remove tandem: Tandem.REQUIRED until phetsims/tandem#253 has been completed.
The text was updated successfully, but these errors were encountered:
phetsims/tandem#253 has been closed, and this issue has been dealt with accordingly, by removing Tandem.REQUIRED and replacing with a PickRequired. Closing.
In #78 @marlitas and I observed this review comment:
This issue requires further discussion, so we are promoting that REVIEW comment to this issue.
We would like to add
PickRequired<PhetioObjectOptions, 'tandem'>
to the options, but we don't want to removetandem: Tandem.REQUIRED
until phetsims/tandem#253 has been completed.The text was updated successfully, but these errors were encountered: