You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PipeModel and WaterCupModel (and their IOTypes) have options and fields named x and y. For example in PipeMode.ts:
typeStateObject={x: number;y: number;}typeSelfOptions={//REVIEW non-obvious options are supposed to be documented where defined, and these are not obvious to the reviewer//REVIEW if x and y are the pipe's position, then position: Vector2 is preferablex: number;y: number;isOpen?: boolean;};
...
publicreadonly x: number;
public readonlyy: number;``` While `x` and `y` are undocumented, I gather that they are the position of the model element. In that case `position: Vector2` isgenerallypreferred.Alsonotealsofromthe CRC:
>-[]PhETpreferstousetheterm"position"torefertothephysical(x,y)positionofobjects.Thisappliestobothbrands,butismoreimportantforthePhET-iOAPI.Seehttps://github.com/phetsims/phet-info/issues/126
The text was updated successfully, but these errors were encountered:
For code review #41 ...
PipeModel and WaterCupModel (and their IOTypes) have options and fields named
x
andy
. For example in PipeMode.ts:The text was updated successfully, but these errors were encountered: