Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving visibility Properties to the view #72

Closed
pixelzoom opened this issue Jun 28, 2022 · 1 comment
Closed

Consider moving visibility Properties to the view #72

pixelzoom opened this issue Jun 28, 2022 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

For code review #41 ...

These Properties are currently in IntroModel.ts:

    this.isShowingPredictMeanProperty = new BooleanProperty( false, {
      tandem: options.tandem.createTandem( 'isShowingPredictMeanProperty' )
    } );
    this.isShowingMeanProperty = new BooleanProperty( false, {
      tandem: options.tandem.createTandem( 'isShowingMeanProperty' )
    } );
    this.isShowingTickMarksProperty = new BooleanProperty( false, {
      tandem: options.tandem.createTandem( 'isShowingTickMarksProperty' )
    } );

They have nothing to do with the model. And more importantly, PhET-iO clients may expect them to be in the view. So consider moving them to IntroScreenView. For an example, see geometric-options.VisibleProperties.

@marlitas
Copy link
Contributor

Visibility properties have been moved to the view. Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants