-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention for naming model-element classes #70
Labels
Comments
Be careful to preserve git history when renaming files. WebStorm/git can be a bit unpredictable about how it handles renames. |
Also by convention, parameters and fields of type PipeModel and WaterCupModel should be renamed. For example, in WaterCup2DNode.ts: - private readonly waterCupModel: WaterCupModel;
+ private readonly waterCup: WaterCup; |
marlitas
added a commit
that referenced
this issue
Jul 19, 2022
marlitas
added a commit
that referenced
this issue
Jul 19, 2022
marlitas
added a commit
that referenced
this issue
Jul 19, 2022
marlitas
added a commit
that referenced
this issue
Jul 19, 2022
Models renamed. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For code review #41 ...
PhET convention does not typically use the suffix "Model" for naming model-element classes. So recommended to rename:
IntroModel is fine, since it is PhET convention to name the top-level model "container" with a "Model" suffix.
The text was updated successfully, but these errors were encountered: