-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PhET convention for naming Properties related to visibility. #59
Labels
Comments
All property names changed. Closing. |
Reopening. I don't see any commits associated with this issue. And I still see the "isShowing" names being used in IntroModel.ts: public readonly isShowingPredictMeanProperty: BooleanProperty;
public readonly isShowingMeanProperty: BooleanProperty;
public readonly isShowingTickMarksProperty: BooleanProperty; |
marlitas
added a commit
that referenced
this issue
Jul 13, 2022
marlitas
added a commit
that referenced
this issue
Jul 13, 2022
marlitas
added a commit
that referenced
this issue
Jul 13, 2022
Closing. Commits now pushed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For code review #41 ...
In IntroModel.ts:
The "isShowing" prefix here does not match PhET/PhET-iO naming conventions.
For Properties that control visibility, the convention is to give them names (and tandem names) of the form
{something}VisibleProperty
.So these should Properties and their tandems should be renamed to
predictMeanVisibleProperty
,meanVisibleProperty
, andtickMarksVisiblePropery
.The text was updated successfully, but these errors were encountered: