You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expected to see PIPE_STROKE_WIDTH used as the value for lineWidth option, perhaps in PipeNode.ts. But it only appears in 1 place in the entire sim, in PipeNode.ts:
So I suspect that you're relying on scenery's default lineWidth (1), and that if I changed that lineWidth or PIPE_STROKE_WIDTH, it would break this code.
So recommendations:
Rename PIPE_STROKE_WIDTH to PIPE_LINE_WIDTH
Set lineWidth: PIPE_LINE_WIDTH as appropriate for components of PipeNode
The text was updated successfully, but these errors were encountered:
For code review #41 ...
In MeanShareAndBalanceConstants.ts:
I expected to see PIPE_STROKE_WIDTH used as the value for
lineWidth
option, perhaps in PipeNode.ts. But it only appears in 1 place in the entire sim, in PipeNode.ts:So I suspect that you're relying on scenery's default
lineWidth
(1), and that if I changed that lineWidth or PIPE_STROKE_WIDTH, it would break this code.So recommendations:
PIPE_STROKE_WIDTH
toPIPE_LINE_WIDTH
lineWidth: PIPE_LINE_WIDTH
as appropriate for components of PipeNodeThe text was updated successfully, but these errors were encountered: