You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By PhET-iO convention, tandem names are typically supposed to match their associated variable/field name (with exceptions made for unusual cases). There are at least 5 violations of that in this sim, and none of them qualifies as "unusual".
For example, in MeanShareAndBalanceScreenView.ts:
this.syncDataButton = new RectangularPushButton( {
...
tandem: options.tandem.createTandem( 'syncRepresentationsButton' ),
I added comment "//REVIEW tandem name does not match" to all of the cases that I identified. (Not necessarily a complete list.)
The text was updated successfully, but these errors were encountered:
pixelzoom
changed the title
Tandem name should match associated variable/property name
Tandem name should match associated variable/field name
Jun 29, 2022
For code review #41 ...
By PhET-iO convention, tandem names are typically supposed to match their associated variable/field name (with exceptions made for unusual cases). There are at least 5 violations of that in this sim, and none of them qualifies as "unusual".
For example, in MeanShareAndBalanceScreenView.ts:
I added comment "//REVIEW tandem name does not match" to all of the cases that I identified. (Not necessarily a complete list.)
The text was updated successfully, but these errors were encountered: