We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge
For code review #41 ...
There's an occurrence of merge in MeanShareAndBalanceScreenView.ts:
this.questionBar = new QuestionBar( this.layoutBounds, this.visibleBoundsProperty, merge( { tandem: options.tandem.createTandem( 'questionBar' ) }, { labelText: meanShareAndBalanceStrings.levelingOutQuestion, barFill: '#2496D6' } ) );
I was going to suggest converting to optionize. But both of the arguments are object literals, so can't they be combined, like this?
optionize
this.questionBar = new QuestionBar( this.layoutBounds, this.visibleBoundsProperty, { labelText: meanShareAndBalanceStrings.levelingOutQuestion, barFill: '#2496D6', tandem: options.tandem.createTandem( 'questionBar' ) } );
The text was updated successfully, but these errors were encountered:
Remove QuestionBar merge, see: #48
b7aec4c
Merge removed. Closing.
Sorry, something went wrong.
marlitas
No branches or pull requests
For code review #41 ...
There's an occurrence of
merge
in MeanShareAndBalanceScreenView.ts:I was going to suggest converting to
optionize
. But both of the arguments are object literals, so can't they be combined, like this?The text was updated successfully, but these errors were encountered: