You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In most PhET sims, each screen has a unique color and unique keyboard-help content. So those options feel inappropriate in this base class. I recommend:
Move backgroundColorProperty and keyboardHelpNode options to IntroScreenView.ts
Rename screenBackgroundColorProperty to introScreenBackgroundColorProperty
That will put you (or the next developer) in a better position to add screens to this sim.
This also brings up the question of whether MeanShareAndBalanceScreen serves any purpose. Because if you remove those options, it's not doing anything. I would probably delete MeanShareAndBalanceScreen.ts for now, and wait to see if a base class is needed when future screens are added.
The text was updated successfully, but these errors were encountered:
MeanShareAndBalanceScreen has been deleted, and backgroundColorProperty and keyboardHelpNode options have been moved to the appropriate classes. Closing.
For code review #41 ...
In MeanShareAndBalanceScreen.ts:
In most PhET sims, each screen has a unique color and unique keyboard-help content. So those options feel inappropriate in this base class. I recommend:
backgroundColorProperty
andkeyboardHelpNode
options to IntroScreenView.tsscreenBackgroundColorProperty
tointroScreenBackgroundColorProperty
That will put you (or the next developer) in a better position to add screens to this sim.
This also brings up the question of whether
MeanShareAndBalanceScreen
serves any purpose. Because if you remove those options, it's not doing anything. I would probably delete MeanShareAndBalanceScreen.ts for now, and wait to see if a base class is needed when future screens are added.The text was updated successfully, but these errors were encountered: