Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model.md #33

Closed
marlitas opened this issue Jun 10, 2022 · 6 comments
Closed

model.md #33

marlitas opened this issue Jun 10, 2022 · 6 comments
Assignees
@marlitas
Labels
documentation Improvements or additions to documentation

Comments

@marlitas
Copy link
Contributor

From CRC: Does it adequately describe the model, in terms appropriate for teachers? Has it been reviewed by the sim designer?
@marlitas marlitas self-assigned this Jun 10, 2022
@marlitas marlitas added the documentation Improvements or additions to documentation label Jun 10, 2022
marlitas added a commit that referenced this issue Jun 10, 2022
@marlitas
Write first draft of model.md, see: #33
8c8a2b2
@marlitas marlitas mentioned this issue Jun 23, 2022
Closed
74 tasks
pixelzoom added a commit that referenced this issue Jun 28, 2022
@pixelzoom
corrected some typos for code review, #33
420c387
@samreid
Copy link
Member

samreid commented Aug 22, 2022

@marlitas and I observed that the model.md file needs to be adjusted based on recent design and implementation changes, thanks!

marlitas added a commit that referenced this issue Aug 23, 2022
@marlitas
Update documentation, see: #33
3802ae0
@marlitas
Copy link
Contributor Author

model.md has been updated to reflect the most recent changes to the intro screen. @pixelzoom, can you review the changes?

@marlitas marlitas assigned pixelzoom and unassigned marlitas Aug 23, 2022
@pixelzoom
Copy link
Contributor

Looks good to me. But the designer typically signs off on model.md, so assigning to @amanda-phet for review.

@pixelzoom pixelzoom assigned amanda-phet and unassigned pixelzoom Aug 23, 2022
amanda-phet added a commit that referenced this issue Aug 26, 2022
@amanda-phet
Update model.md
c7fd751 
#33
@amanda-phet
Copy link
Contributor

I made a few edits, and also commented out a paragraph that I think is a little confusing and not necessary. I'll discuss with @marlitas what to do about that paragraph.

amanda-phet added a commit that referenced this issue Aug 26, 2022
@amanda-phet
Update model.md
a94483a 
#33
@amanda-phet
Copy link
Contributor

I made one edit to that paragraph.

Over to @marlitas to confirm if it all looks ok.

@amanda-phet amanda-phet assigned marlitas and unassigned amanda-phet Aug 26, 2022
marlitas added a commit that referenced this issue Aug 26, 2022
@marlitas
Add commas, see: #33
8dbccd1
@marlitas
Copy link
Contributor Author

Looks great. I added a couple of commas, but other than that looks good to me. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlitas marlitas

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @pixelzoom @amanda-phet @marlitas