Water valve design

[amanda-phet]

The current valve is a simple circle with a cutout, and doesn't necessarily look interactive:

@marlitas came up with an idea that is kind of like a gate valve that is pretty awesome:

@samreid and @marlitas and I brainstormed how we could build on this idea and thought about making the height difference between on and off more stark, making the pin darker, and maybe even showing no pipe between cups of water if the valve is closed.

I still liked the idea of the ball valve inspiration where we can see water flowing between cups and tried to play with that idea some more. @ariel-phet and I met to discuss some ways to make that work and ended up with this idea:

The pipe is opaque (and has a gradient to look like metal), but when you turn (click on) the valve/handle, you can see water flowing through the pipe. That seems to solve some issues of where the water came from, since it is hidden from view. This handle also feels similar to the handles for water pipes I have in my home, so it's familiar in that sense if someone has ever seen a pipe like this before. However there are still some sizing issues (the handle seems small) to work out. But I wanted to see what the rest of the team thinks about this direction.

[samreid]

Another option discussed on Wednesday with @amanda-phet and @marlitas was that the water cups are not connected by default. A cross section of a pipe coming "out of the screen" would be shown between cups. Clicking on it would rotate it 3D-ish until the cups are connected.

[amanda-phet]

Discussed 6/15/22 and still not sure which direction to go.. I'd like to run these ideas by @kathy-phet and also see if our graphic artist could help make things look nicer before making any changes in the code.

[amanda-phet]

@marlitas made a version to match the new mockup! It's really helpful to see it in context:

I saw some minor issues, but before we polish it I think it would be helpful to decide if we like this direction.

[amanda-phet]

Discussed again 6/15/22, and @marlitas will keep the valve with the red handle. Some tweaks:

• reduce the overall size of the valve a bit
• reduce the length of the handle so it doesn't cover the cup
• change the pipe color to be a gradient from white to gray (#4d4d4d) - simple linear gradient

[marlitas]

Valve redesign according to notes is done and pushed up to master. Assigning to @amanda-phet for review and feedback.

[amanda-phet]

Let's review this with the team on Thursday. A lot of discussions and design progress have happened and everyone who wants to weight in should review the latest version.

[amanda-phet]

We are considering moving the whole valve over so that it is "centered" when the valve is in the open position.

@marlitas can you let us know when this is ready for review, and possibly add a screenshot here?

[marlitas]

Valve position has been adjusted and is ready for review. Here's a screenshot to look over before tomorrow's meeting.

[amanda-phet]

Reviewed in 7/21/22 design meeting and everyone likes it!