-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table & Notebook Paper Cup Spaces #102
Comments
I added in the artwork for the notebook paper and table. Below are screenshots of what that's looking like: I scaled the paper down so that it would fit all the cup and chocolate representations while keeping a small but decent margin on the sides, however in the LevelingOut screen this begins to infiltrate the people and table area. My current suggestion would be to see if we can make the paper a bit shorter, but we can also play with the sizing of objects. Sending to @amanda-phet for feedback! |
@amanda-phet I saw a partyTable.png was added to images. I added that to the licenses json to avoid CT errors, and wanted to confirm that the artist is Mariah Hermsmeyer |
Yes that's correct. |
I referenced the wrong issue in the above commits "Expand no-simple-type-checking-assertions regex". The correct issue is: phetsims/chipper#1344 |
@amanda-phet I wanted to check and see if there are any other lines in the paper area you would like to look like pencil strokes? I switched the 2D cup strokes and pipe strokes to the pencil pattern you provided, but was unsure if you wanted something similar for the meanLine, waterLine, and tickMarks (in their respective colors). Here is a screenshot showing the current state as it is now: |
@samreid and I met with @mariahmaephet today and were able to add in the notepad artwork with a combination of code and png. Here's a screenshot of what it's looking like. Personally I think it's fun without being distracting. @amanda-phet let me know your thoughts. We are going to be pushing forward with an RC for this in the coming week. |
I also want to note that I'd like a softer color for the paper and not pure white. Did you try #F0F0F0? That's what the paper was previously. |
@amanda-phet we can definitely make these changes. Do you want these changes to be included in the prototype for the Intro Screen, or just as we move forward? |
On Slack:
|
Those changes are applied and pushed up. @amanda-phet can you confirm this change or not? If yes, I can mark this for cherry-pick for RC 2. |
Looks good! Thanks! |
Looks good in rc.2. Closing |
This issue will track changes, design decisions, and feedback for the two data spaces in the intro screen.
Initial Mock-Up for the separate data spaces:
The text was updated successfully, but these errors were encountered: