Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table & Notebook Paper Cup Spaces #102

Closed
marlitas opened this issue Aug 26, 2022 · 13 comments
Closed

Table & Notebook Paper Cup Spaces #102

marlitas opened this issue Aug 26, 2022 · 13 comments

Comments

@marlitas
Copy link
Contributor

marlitas commented Aug 26, 2022

This issue will track changes, design decisions, and feedback for the two data spaces in the intro screen.

Initial Mock-Up for the separate data spaces:
Screen Shot 2022-08-26 at 8 45 47 AM

marlitas added a commit that referenced this issue Aug 26, 2022
@marlitas marlitas self-assigned this Aug 26, 2022
@marlitas
Copy link
Contributor Author

I added in the artwork for the notebook paper and table. Below are screenshots of what that's looking like:
Screen Shot 2022-09-13 at 4 06 22 PM
Screen Shot 2022-09-13 at 4 06 28 PM

I scaled the paper down so that it would fit all the cup and chocolate representations while keeping a small but decent margin on the sides, however in the LevelingOut screen this begins to infiltrate the people and table area. My current suggestion would be to see if we can make the paper a bit shorter, but we can also play with the sizing of objects.

Sending to @amanda-phet for feedback!

@marlitas marlitas assigned amanda-phet and unassigned marlitas Sep 14, 2022
@marlitas
Copy link
Contributor Author

@amanda-phet I saw a partyTable.png was added to images. I added that to the licenses json to avoid CT errors, and wanted to confirm that the artist is Mariah Hermsmeyer

marlitas added a commit that referenced this issue Oct 18, 2022
@amanda-phet
Copy link
Contributor

Yes that's correct.

@marlitas
Copy link
Contributor Author

I referenced the wrong issue in the above commits "Expand no-simple-type-checking-assertions regex". The correct issue is: phetsims/chipper#1344

@marlitas
Copy link
Contributor Author

@amanda-phet I wanted to check and see if there are any other lines in the paper area you would like to look like pencil strokes? I switched the 2D cup strokes and pipe strokes to the pencil pattern you provided, but was unsure if you wanted something similar for the meanLine, waterLine, and tickMarks (in their respective colors).

Here is a screenshot showing the current state as it is now:
Screen Shot 2022-10-27 at 12 51 52 PM

@marlitas
Copy link
Contributor Author

marlitas commented Nov 1, 2022

@samreid and I met with @mariahmaephet today and were able to add in the notepad artwork with a combination of code and png. Here's a screenshot of what it's looking like. Personally I think it's fun without being distracting. @amanda-phet let me know your thoughts. We are going to be pushing forward with an RC for this in the coming week.

Screenshot 2022-10-31 at 10 24 50 PM

marlitas added a commit that referenced this issue Nov 1, 2022
@amanda-phet
Copy link
Contributor

The style of the notebook looks good to me. I think we should use more spiral loops, though. Can you use 8 instead of 6?

image

@amanda-phet
Copy link
Contributor

I also want to note that I'd like a softer color for the paper and not pure white. Did you try #F0F0F0? That's what the paper was previously.

@amanda-phet amanda-phet removed their assignment Nov 9, 2022
@marlitas
Copy link
Contributor Author

marlitas commented Nov 9, 2022

@amanda-phet we can definitely make these changes. Do you want these changes to be included in the prototype for the Intro Screen, or just as we move forward?

@marlitas marlitas assigned amanda-phet and marlitas and unassigned marlitas and amanda-phet Nov 9, 2022
@marlitas
Copy link
Contributor Author

marlitas commented Nov 9, 2022

On Slack:
@amanda-phet

If you're going to do another RC anyway, can we include this as a change?

@marlitas

Yeah for sure! I’ll make that change and ping you when it’s done. 🙂

@marlitas
Copy link
Contributor Author

marlitas commented Nov 9, 2022

Those changes are applied and pushed up. @amanda-phet can you confirm this change or not? If yes, I can mark this for cherry-pick for RC 2.

@marlitas marlitas assigned amanda-phet and unassigned marlitas Nov 9, 2022
@amanda-phet
Copy link
Contributor

Looks good! Thanks!

@KatieWoe
Copy link

Looks good in rc.2. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants