Make MeanShareAndBalanceModel.ts abstract, see: #45

js/common/model/MeanShareAndBalanceModel.ts

@@ -16,30 +16,24 @@ type SelfOptions = EmptyObjectType;
 
 export type MeanShareAndBalanceModelOptions = SelfOptions & PickRequired<PhetioObjectOptions, 'tandem'>;
 
-export default class MeanShareAndBalanceModel {
+export default abstract class MeanShareAndBalanceModel {
 
-  public constructor( providedOptions: MeanShareAndBalanceModelOptions ) {
+  protected constructor( providedOptions: MeanShareAndBalanceModelOptions ) {
     // Here for potential future use.
   }
 
-  public syncData(): void {
-    // See subclass for implementation
-  }
+  public abstract syncData(): void
 
   /**
    * Resets the model.
    */
-  public reset(): void {
-    // See subclass for implementation
-  }
+  public abstract reset(): void
 
   /**
    * Steps the model.
    * @param dt - time step, in seconds
    */
-  public step( dt: number ): void {
-    // See subclass for implementation
-  }
+  public abstract step( dt: number ): void
 }
 
 meanShareAndBalance.register( 'MeanShareAndBalanceModel', MeanShareAndBalanceModel );

js/intro/model/IntroModel.ts

@@ -257,8 +257,7 @@ export default class IntroModel extends MeanShareAndBalanceModel {
    * Will close all open pipe valves
    * Called when the syncDataRectangularButton is pressed.
    */
-  public override syncData(): void {
-    super.syncData();
+  public syncData(): void {
     this.assertConsistentState();
     this.isAutoSharingProperty.set( false );
     this.pipeGroup.forEach( pipe => pipe.isOpenProperty.set( false ) );
@@ -277,11 +276,10 @@ export default class IntroModel extends MeanShareAndBalanceModel {
   /**
    * @param dt - in seconds
    */
-  public override step( dt: number ): void {
+  public step( dt: number ): void {
 
     this.assertConsistentState();
 
-    super.step( dt );
     this.stepWaterLevels( dt );
 
     assert && assert( !phet.joist.sim.isSettingPhetioStateProperty.value, 'Cannot step while setting state' );
@@ -309,8 +307,7 @@ export default class IntroModel extends MeanShareAndBalanceModel {
     assert && assert( this.waterCup3DGroup.count - 1 === this.pipeGroup.count, `The length of pipes is: ${this.pipeGroup.count}, but should be one less the length of water cups or: ${this.waterCup3DGroup.count - 1}.` );
   }
 
-  public override reset(): void {
-    super.reset();
+  public reset(): void {
     this.isShowingPredictMeanProperty.reset();
     this.isShowingMeanProperty.reset();
     this.isShowingTickMarksProperty.reset();

js/leveling-out/model/LevelingOutModel.ts

@@ -70,6 +70,19 @@ export default class LevelingOutModel extends MeanShareAndBalanceModel {
     }
   }
 
+  public override reset(): void {
+    this.isMeanAccordionExpandedProperty.reset();
+    this.numberOfPeopleProperty.reset();
+  }
+
+  public syncData(): void {
+    // future implementation
+  }
+
+  public step( dt: number ): void {
+    // future implementation
+  }
+
 }
 
 meanShareAndBalance.register( 'LevelingOutModel', LevelingOutModel );