Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy Legend suggestions #297

Closed
pixelzoom opened this issue Jun 19, 2018 · 5 comments
Closed

Energy Legend suggestions #297

pixelzoom opened this issue Jun 19, 2018 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 19, 2018

Noted while working on phetsims/joist#413.

masses-and-springs and pendulum-lab both have a dialog titled "Energy Legend"., but their styling is different.

masses-and-springs:

screenshot_678

pendulum-lab:

screenshot_679

Consider making the title larger and the font of the symbols bold in masses-and-springs.

@Denz1994
Copy link
Contributor

Checking for quick fix.

@arouinfar
Copy link

arouinfar commented Jun 19, 2018

Thanks @pixelzoom. That is a great suggestion.

@Denz1994 a few tweaks for you

  • Font sizes should match pendulum-lab
  • Make energy symbols bold
  • Total energy abbreviation should be E_total, not E_tot.

@Denz1994
Copy link
Contributor

Can you double check the fixes in master @arouinfar?

@arouinfar
Copy link

Looks great, thanks @Denz1994!

@arouinfar
Copy link

While this was not technically for phetsims/qa#129, I'm going to go ahead and tag it so it shows up in the RC issue. That way, it'll be easier to keep track of the changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants