Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Mass" title occluded by icon under i18n #294

Closed
arouinfar opened this issue Jun 18, 2018 · 2 comments
Closed

"Mass" title occluded by icon under i18n #294

arouinfar opened this issue Jun 18, 2018 · 2 comments

Comments

@arouinfar
Copy link

For phetsims/qa#129

The string should expand to the right so that the relative spacing between the icon and "Mass" remains the same.

image

@Denz1994
Copy link
Contributor

There are some limitations on how the title expands based on the common code. Without creating a new numberControl scheme for this specific case, could we try reversing the massString and its icon?

This pattern of description/readout/title on the left followed by its icon on the right seems to be standard for the other panels as well, such as the reference line panel and vector indicator panel. It would also save a lot of time. Is this acceptable @arouinfar? Check in master.

@arouinfar
Copy link
Author

Thanks for clarifying @Denz1994. Moving the icon to the right looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants