Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance check? #259

Closed
jonathanolson opened this issue Mar 13, 2018 · 4 comments
Closed

Performance check? #259

jonathanolson opened this issue Mar 13, 2018 · 4 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

I'm not able to test on a range of lower-performance devices. As part of the code review, it wants a performance check.

@phet-steele, is performance acceptable, and/or is there anything that could be improved?

See #253

@phet-steele
Copy link
Contributor

I probably won't have time for this, and @jonathanolson I know you have an iPad 2. That's all you need.

@jonathanolson
Copy link
Contributor Author

@lmulhall-phet, can you let me know how the performance looks as part of the QA tests for https://bayes.colorado.edu/dev/html/masses-and-springs/1.0.0-dev.102/phet/masses-and-springs_all_phet.html?

If it needs improvement, I'll be available for collaboration with @Denz1994.

@jonathanolson jonathanolson assigned Denz1994 and ghost and unassigned jonathanolson and Denz1994 May 22, 2018
@ghost
Copy link

ghost commented Jun 1, 2018

@jonathanolson, I tested the latest dev on an iPad 2, and IMO the performance is not great, but acceptable.

EDIT: The dev version you linked above has a bug that breaks the sim, hence testing it on a newer dev.

@ghost ghost assigned jonathanolson and unassigned ghost Jun 1, 2018
@Denz1994
Copy link
Contributor

Being that phetsims/qa#122, phetsims/qa#126, and #285 were closed and perfromanced was measured several times in the last month of testing, I'm closing this issue. iPad 2 performance seems accemptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants