-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon to mass panel #250
Comments
One cute little mass icon coming up. |
@arouinfar Can you check this dev version for review? |
Panel changes were made on master @arouinfar? |
@Denz1994 it looks like trimming off the extra padding from the top of the panel shifted the icon down. |
What about now @arouinfar? Try in master. |
Getting closer @Denz1994, but it's still not quite centered |
Sorry for the constant commits. Could you try master now @arouinfar? |
Mass icon looks great! I've noticed that the "Mass" string looks way smaller than other slider titles. Can you bump it up to 14pt to match the others? |
The mass string was smaller, due to the size of the panel it is contained in. I made the panel a bit larger so the string also increased in size. What do you think @arouinfar? |
Sorry to keep kicking this back to you @Denz1994, but the font size still looks pretty small. Can you bump it up a bit more? It's okay if the panel ends up slightly larger. |
There was a problem with the overall layout of the contentNode of the panel. We needed to remove the force vectors from the mass icon. The icon created bounds to include them despite not being visible. This makes the adjustment of fonts and positioning the panel's content a lot less hacky. Could you review the massValueControlPanel in master @arouinfar? |
Getting really close @Denz1994!! Alignment looks good, but the relative font sizes look a bit off. The min/max labels look too large, and the readout looks a bit too small. The min/max/readout should all be the same size, as in the Gravity slider (12 pt, I believe). |
The max width on the readout was too constraining. It has been made larger and the fonts were not the same size for the min/max labels. Could you check in master @arouinfar? |
Looking good! |
On the Lab screen, it may not be immediately clear which mass the slider is adjusting. After discussion with @ariel-phet we decided that adding an iconic mass to the panel would address this issue. @Denz1994 can you add an iconic adjustable mass to the left of the "Mass" title? Here's a mockup:
The text was updated successfully, but these errors were encountered: