Skip to content

Commit

Permalink
Addressed REVIEW: Refactoring this.springNodes reference phetsims/mas…
Browse files Browse the repository at this point in the history
  • Loading branch information
Denz1994 committed Jan 30, 2019
1 parent 8e9f96d commit d9941f3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions js/common/view/SpringScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,7 @@ define( function( require ) {
this.springBackColorProperty = new PaintColorProperty( 'black' );

// @private {Array.<MutableOptionsNode>} Used to reference the created springs in the view.
this.springNodes = [];
// REVIEW: Don't use `self`, and can we just combine this into the "declaration" above?
self.springNodes = model.springs.map( function( spring ) {
this.springNodes = model.springs.map( function( spring ) {
var springNode = new MutableOptionsNode( OscillatingSpringNode,
[ spring, self.modelViewTransform, tandem.createTandem( 'oscillatingSpringNode' ) ],
{ leftEndLength: -10 },
Expand Down

0 comments on commit d9941f3

Please sign in to comment.