More alignment adjustments for panels and lint fixes. #293

phetsims · Jul 17, 2018 · 3904211 · 3904211
1 parent 22e5d61
commit 3904211
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 10 deletions.
diff --git a/js/common/view/GravityAndDampingControlNode.js b/js/common/view/GravityAndDampingControlNode.js
@@ -124,10 +124,10 @@ define( function( require ) {
       valuePattern: StringUtils.fillIn( gravityValueString, {
         gravity: '{0}'
       } ),
-      valueFont: new PhetFont( { size: 14} ),
+      valueFont: new PhetFont( { size: 14 } ),
       useRichText: true,
       decimalPlaces: 1,
-      valueMaxWidth: MAX_WIDTH * 2,
+      valueMaxWidth: MAX_WIDTH * 3,
       delta: 0.1,
       arrowButtonScale: 0.5
     };

diff --git a/js/common/view/LineVisibilityNode.js b/js/common/view/LineVisibilityNode.js
@@ -35,7 +35,7 @@ define( function( require ) {
     options = _.extend( {
       massEquilibrium: false,
       fill: MassesAndSpringsConstants.PANEL_FILL,
-      tandem: tandem.createTandem( 'LineVisibilityNode' ),
+      tandem: tandem.createTandem( 'LineVisibilityNode' )
     }, options );
 
     Node.call( this, options );

diff --git a/js/common/view/SpringScreenView.js b/js/common/view/SpringScreenView.js
@@ -318,7 +318,9 @@ define( function( require ) {
      * @return {IndicatorVisibilityControlNode}
      */
     createIndicatorVisibilityPanel: function( model, displayPeriodTrace, tandem ) {
-      return new IndicatorVisibilityControlNode( model, tandem.createTandem( 'indicatorVisibilityControlNode' ) );
+      return new IndicatorVisibilityControlNode( model, tandem.createTandem( 'indicatorVisibilityControlNode' ),{
+        periodTraceOption: displayPeriodTrace
+      } );
     },
 
     /**

diff --git a/js/vectors/view/IndicatorVisibilityControlNode.js b/js/vectors/view/IndicatorVisibilityControlNode.js
@@ -110,7 +110,7 @@ define( function( require ) {
     }, {
       content: new Text( movableLineString, {
         font: MassesAndSpringsConstants.TITLE_FONT,
-        maxWidth: 225,
+        maxWidth: 215,
         tandem: tandem.createTandem( 'movableLineString' )
       } ),
       property: model.movableLineVisibleProperty
@@ -134,7 +134,7 @@ define( function( require ) {
       }, {
         content: new Text( movableLineString, {
           font: MassesAndSpringsConstants.TITLE_FONT,
-          maxWidth: 225,
+          maxWidth: 215,
           tandem: tandem.createTandem( 'movableLineString' )
         } ),
         property: model.movableLineVisibleProperty
@@ -185,7 +185,7 @@ define( function( require ) {
       } );
     }
     var controlBox = new HBox( {
-      spacing: 25,
+      spacing: 23,
       children: [
         indicatorVisibilityControlsVBox,
         lineVBox

diff --git a/js/vectors/view/VectorVisibilityControlNode.js b/js/vectors/view/VectorVisibilityControlNode.js
@@ -83,15 +83,15 @@ define( function( require ) {
     var forcesVisibilityCheckboxGroup = new VerticalCheckboxGroup( [ {
       content: new Text( gravityString, {
         font: MassesAndSpringsConstants.TITLE_FONT,
-        maxWidth: MAX_WIDTH - 22,
+        maxWidth: MAX_WIDTH,
         tandem: tandem.createTandem( 'gravityString' )
       } ),
       property: model.gravityVectorVisibilityProperty,
       label: gravityString
     }, {
       content: new Text( springString, {
         font: MassesAndSpringsConstants.TITLE_FONT,
-        maxWidth: MAX_WIDTH - 22,
+        maxWidth: MAX_WIDTH,
         tandem: tandem.createTandem( 'springString' )
       } ),
       property: model.springVectorVisibilityProperty,
@@ -196,7 +196,7 @@ define( function( require ) {
       } );
     }
     var controlsHBox = new HBox( {
-      spacing: 40,
+      spacing: 55,
       children: [
         vectorVisibilityControlsVBox,
         vectorVBox