Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow panel/toolbox on right side to expand 50px before scaling down strings #18

Closed
arouinfar opened this issue Oct 10, 2018 · 4 comments

Comments

@arouinfar
Copy link
Contributor

Similar to phetsims/masses-and-springs#293

@Denz1994 can you allow the the panels on the right to expand a bit before scaling down the strings? The behavior can match MAS.

Things are looking a bit crowded even for ?stringTest=double
image

To keep things looking uniform, the gravity accordion box and toolbox should get wider to match the width of the panel above.

@Denz1994
Copy link
Contributor

@arouinfar We adjusted the size of the spring constant panels. Do we still want this pixel expansion, especially on Bounce and Stretch screens?

@Denz1994 Denz1994 added the type:question Further information is requested label Oct 31, 2018
@arouinfar
Copy link
Contributor Author

Good point @Denz1994. This request was made before the spring constant panels were widened. Things are currently a bit tight:
image

Rather than expand the panel, could you extend the maxWidth so the strings get a bit closer to the icon? Currently, there's quite a bit of dead space between the string and icon.

@arouinfar arouinfar removed their assignment Oct 31, 2018
@Denz1994
Copy link
Contributor

Denz1994 commented Nov 2, 2018

The maxWidth has been adjusted to allow for the labels to expand closer to their respective icon. Please review master in MAS and MASB @arouinfar.

@Denz1994 Denz1994 assigned arouinfar and unassigned Denz1994 Nov 2, 2018
@Denz1994 Denz1994 added status:ready-for-review and removed type:question Further information is requested labels Nov 2, 2018
Denz1994 added a commit to phetsims/masses-and-springs that referenced this issue Nov 6, 2018
@arouinfar
Copy link
Contributor Author

Looks good @Denz1994!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants