Skip to content

Commit

Permalink
Addressing TODO: Using PaintColorProperty.value to fix doc inconsiste…
Browse files Browse the repository at this point in the history
…ncy.

#48
  • Loading branch information
Denz1994 committed Jan 18, 2019
1 parent 21889c5 commit c20593d
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions js/stretch/view/StretchScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,9 @@ define( require => {
);

// Setting specific colors for this screen's springs.
// REVIEW: This is setting the value of PaintColorProperty, which is generally meant only for it internally to do
// REVIEW: itself. It's effectively making e.g. springFrontColorProperty into a Property.<PaintColorProperty>,
// REVIEW: but it is documented as {PaintColorProperty} itself.
this.springFrontColorProperty.set( new PaintColorProperty( 'rgb( 162, 106, 172 )' ) );
this.springMiddleColorProperty.set( new PaintColorProperty( 'rgb( 100, 6, 117 )' ) );
this.springBackColorProperty.set( new PaintColorProperty( 'rgb( 50, 3, 58 )' ) );
this.springFrontColorProperty.set( new PaintColorProperty( 'rgb( 162, 106, 172 )' ).value );
this.springMiddleColorProperty.set( new PaintColorProperty( 'rgb( 100, 6, 117 )' ).value );
this.springBackColorProperty.set( new PaintColorProperty( 'rgb( 50, 3, 58 )' ).value );

// Adding system controls to scene graph
this.addChild( this.springSystemControlsNode );
Expand Down

0 comments on commit c20593d

Please sign in to comment.