Skip to content

Commit

Permalink
Addressed TODO: Phet-io tandems for Text
Browse files Browse the repository at this point in the history
  • Loading branch information
Denz1994 committed Jan 18, 2019
1 parent 126dc9f commit 9aeb937
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions js/lab/view/GravityAccordionBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,13 @@ define( require => {
} );
gravitySlider.addMajorTick( MassesAndSpringsConstants.GRAVITY_RANGE.min, new Text( noneString, {
font: MassesAndSpringsConstants.LABEL_FONT,
tandem: tandem.createTandem( 'gravityNoneString' ), // REVIEW: Tandem should be for the 'Text', not a 'String'?
tandem: tandem.createTandem( 'gravityNoneText' ), // REVIEW: Tandem should be for the 'Text', not a 'String'?
// *REVIEW: review with JO and update updat
maxWidth: MAX_WIDTH * 0.5
} ) );
gravitySlider.addMajorTick( MassesAndSpringsConstants.GRAVITY_RANGE.max, new Text( lotsString, {
font: MassesAndSpringsConstants.LABEL_FONT,
tandem: tandem.createTandem( 'gravityLotsString' ),
tandem: tandem.createTandem( 'gravityLotsText' ),
maxWidth: MAX_WIDTH * 0.5
} ) );

Expand Down

0 comments on commit 9aeb937

Please sign in to comment.