Addressed REVIEW: Updating tandem reference to screenView. #48

phetsims · Jan 23, 2019 · 8c39cb6 · 8c39cb6
1 parent 90a9744
commit 8c39cb6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/js/bounce/BounceScreen.js b/js/bounce/BounceScreen.js
@@ -49,7 +49,6 @@ define( require => {
           model.addDefaultMasses( modelTandem );
           return model;
         },
-        // REVIEW: In general, do we need `tandem.createTandem( 'view' )`?
         model => { return new BounceScreenView( model, tandem.createTandem( 'view' ) ); },
         options
       );

diff --git a/js/lab/LabScreen.js b/js/lab/LabScreen.js
@@ -41,7 +41,7 @@ define( require => {
 
       super(
         () => new LabModel( tandem.createTandem( 'model' ), options ),
-        model => { return new LabScreenView( model, tandem ); },
+        model => { return new LabScreenView( model, tandem.createTandem( 'view' ) ); },
         options
       );
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,7 +41,7 @@ define( require => { @@
           super(
             () => new LabModel( tandem.createTandem( 'model' ), options ),
-            model => { return new LabScreenView( model, tandem ); },
+            model => { return new LabScreenView( model, tandem.createTandem( 'view' ) ); },
             options
           );
         }
@@ Expand Down @@