Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit credits #275

Open
amanda-phet opened this issue Mar 1, 2017 · 6 comments
Open

Edit credits #275

amanda-phet opened this issue Mar 1, 2017 · 6 comments
Assignees

Comments

@amanda-phet
Copy link
Contributor

Right now MLL is listed in the credits, but I don't recall them working on this sim. MLL should be removed and replaced with Ashraf.

Sorry for not noticing this earlier!

@jonathanolson
Copy link
Contributor

Fixed in master (let me know if it looks correct). I've also applied the fix to the maintenance-release branch, so this issue can be closed if it looks fine (will track maintenance release in #273).

@phet-steele
Copy link
Contributor

phet-steele commented Mar 1, 2017

@jonathanolson I see the credits fix on 1.0 only, not master. That being said it looks fine, but please alphabetize QA by last name (Bryce would be second).

jonathanolson added a commit that referenced this issue Mar 2, 2017
jonathanolson added a commit that referenced this issue Mar 2, 2017
jonathanolson added a commit that referenced this issue Mar 2, 2017
@jonathanolson
Copy link
Contributor

Pushed change to master, and alphabetization for both master and 1.0

@jonathanolson jonathanolson removed their assignment Mar 2, 2017
@amanda-phet
Copy link
Contributor Author

Looks good in master. Thanks!

@amanda-phet
Copy link
Contributor Author

amanda-phet commented Mar 21, 2018

Chris noticed that graphic arts are incorrectly attributed here to me. They should list Mariah Hermsmeyer for graphic arts. She create the pieces of paper, and all of the PhET girl artwork on the game screen level selection buttons. This needs to be updated in the sim as well as the image license files.

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 30, 2018

Reopening. This one is still wrong, and got propagated to vegas:

  "game-reward.png": {
    "text": [
      "Copyright 2002-2016 University of Colorado Boulder"
    ],
    "projectURL": "http://phet.colorado.edu",
    "license": "contact [email protected]",
    "notes": "created by Amanda McGarry"
  },

According to @amanda-phet, this image was created by Mariah, and Amanda modified it.

Highly recommend to fix this. Or better yet, delete the PNG and .ai from make-a-ten, and use VEGAS/phet-girl-juggling-stars.png. (The artboard for this image is in making-tens-screen-icons.ai, which should also be renamed to make make-a-ten-screen-icons.ai.)

@pixelzoom pixelzoom reopened this Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants