-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit credits #275
Comments
Fixed in master (let me know if it looks correct). I've also applied the fix to the maintenance-release branch, so this issue can be closed if it looks fine (will track maintenance release in #273). |
@jonathanolson I see the credits fix on 1.0 only, not master. That being said it looks fine, but please alphabetize QA by last name (Bryce would be second). |
Pushed change to master, and alphabetization for both master and 1.0 |
Looks good in master. Thanks! |
Chris noticed that graphic arts are incorrectly attributed here to me. They should list Mariah Hermsmeyer for graphic arts. She create the pieces of paper, and all of the PhET girl artwork on the game screen level selection buttons. This needs to be updated in the sim as well as the image license files. |
Reopening. This one is still wrong, and got propagated to vegas: "game-reward.png": {
"text": [
"Copyright 2002-2016 University of Colorado Boulder"
],
"projectURL": "http://phet.colorado.edu",
"license": "contact [email protected]",
"notes": "created by Amanda McGarry"
}, According to @amanda-phet, this image was created by Mariah, and Amanda modified it. Highly recommend to fix this. Or better yet, delete the PNG and .ai from make-a-ten, and use |
Right now MLL is listed in the credits, but I don't recall them working on this sim. MLL should be removed and replaced with Ashraf.
Sorry for not noticing this earlier!
The text was updated successfully, but these errors were encountered: