-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change behavior of number readouts on Adding screen #272
Comments
To clarify, what happens when a number has been previously entered (say in the left), and the user goes back to edit it? When they open the (what will be modal) keypad for it, should it:
|
Option 1 seems best so that if a user accidentally clicks the edit button they can dismiss it without repercussions. The number should only be empty (and thus have a dashed outline with no white fill) on startup or if a user deletes a number then dismisses the keypad. |
Implemented, does that look good? |
It does look good. The one unfortunate thing is that the dimmed background makes the white background less apparent, but it seems fine. The behavior that I specified above is working perfectly. |
Per 2/2/17 discussion:
On startup there should be a dashed outline for each number that has not yet been entered. ANY time this number is empty we see a dashed outline in place of a number (such as when a user deletes a previously entered number).
When actively editing a number, a white background should be in the rectangle.
Once a number has been entered, the rectangle is not visible:
The text was updated successfully, but these errors were encountered: