Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of number readouts on Adding screen #272

Closed
amanda-phet opened this issue Feb 3, 2017 · 4 comments
Closed

Change behavior of number readouts on Adding screen #272

amanda-phet opened this issue Feb 3, 2017 · 4 comments

Comments

@amanda-phet
Copy link
Contributor

Per 2/2/17 discussion:

On startup there should be a dashed outline for each number that has not yet been entered. ANY time this number is empty we see a dashed outline in place of a number (such as when a user deletes a previously entered number).
screen shot 2017-02-03 at 12 02 50 pm

When actively editing a number, a white background should be in the rectangle.
screen shot 2017-02-03 at 12 02 34 pm

Once a number has been entered, the rectangle is not visible:
screen shot 2017-02-03 at 12 08 49 pm

@jonathanolson
Copy link
Contributor

To clarify, what happens when a number has been previously entered (say in the left), and the user goes back to edit it? When they open the (what will be modal) keypad for it, should it:

  1. Keep the old number in the readout (like currently), and have a dashed box with white background (so ANY time this number is empty we see a dashed outline isn't an "if and only if").
  2. Keep the old number in the readout (like currently), with no dashed box (and thus no background).
  3. Remove the old number in the readout, and have a dashed box with white background.

@amanda-phet
Copy link
Contributor Author

Option 1 seems best so that if a user accidentally clicks the edit button they can dismiss it without repercussions. The number should only be empty (and thus have a dashed outline with no white fill) on startup or if a user deletes a number then dismisses the keypad.

@jonathanolson
Copy link
Contributor

Implemented, does that look good?

@amanda-phet
Copy link
Contributor Author

It does look good. The one unfortunate thing is that the dimmed background makes the white background less apparent, but it seems fine. The behavior that I specified above is working perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants