-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Paper" & "total" layering is not the same across screens #266
Comments
Hm, I agree that these should be consistent, but I recall @bethstade having reasons for them layering differently. I would lean toward laying the paper over the text in all screens (including the game screen). |
I agree. Looks like paper should go on top.
Just a reminder, I am out to the country and email will be inconsistent until after Feb. 14th.
…----- Original Message -----From: Amanda McGarry <[email protected]>To: phetsims/make-a-ten <[email protected]>Cc: bethstade <[email protected]>, Mention <[email protected]>Sent: Wed, 01 Feb 2017 18:18:18 -0000 (UTC)Subject: Re: [phetsims/make-a-ten] "Paper" & "total" layering is not the same across screens (#266)
Hm, I agree that these should be consistent, but I recall @bethstade having reasons for them layering differently. I would lean toward laying the paper over the text in all screens (including the game screen).
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
Let's change the logic then, so that paper is layered above text. Thanks for commenting from London, @bethstade ! |
@amanda-phet, how should it layer with the other things (edit buttons and keypad on the adding screen, "next" button on the game)? |
Keypad should be on top (always). |
Made the requested changes. Also the numbers were over "Hide Total" in the first screen (which seemed inconsistent), so I moved that behind the numbers also. Can you review? |
Looks good on the first two screens, but to be consistent the paper numbers should be layered over the text numbers and next button on the game screen. |
Sorry about that, definitely forgot about the formula on the game screen. Should be fixed. |
Ok, should be fixed. |
Looks great, thanks. |
@amanda-phet the layering of the paper on the first screen puts it above the total:
The layering on the 2nd and 3rd screens puts the paper under the total:
Should these be consistent? Which is preferred?
For phetsims/tasks/issues/767.
The text was updated successfully, but these errors were encountered: