Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Paper" & "total" layering is not the same across screens #266

Closed
phet-steele opened this issue Feb 1, 2017 · 11 comments
Closed

"Paper" & "total" layering is not the same across screens #266

phet-steele opened this issue Feb 1, 2017 · 11 comments
Assignees

Comments

@phet-steele
Copy link
Contributor

@amanda-phet the layering of the paper on the first screen puts it above the total:
screen shot 2017-02-01 at 10 43 18 am

The layering on the 2nd and 3rd screens puts the paper under the total:
screen shot 2017-02-01 at 10 43 27 am

Should these be consistent? Which is preferred?

For phetsims/tasks/issues/767.

@amanda-phet
Copy link
Contributor

Hm, I agree that these should be consistent, but I recall @bethstade having reasons for them layering differently. I would lean toward laying the paper over the text in all screens (including the game screen).

@bethstade
Copy link

bethstade commented Feb 1, 2017 via email

@amanda-phet
Copy link
Contributor

Let's change the logic then, so that paper is layered above text. Thanks for commenting from London, @bethstade !

@jonathanolson
Copy link
Contributor

@amanda-phet, how should it layer with the other things (edit buttons and keypad on the adding screen, "next" button on the game)?

@amanda-phet
Copy link
Contributor

Keypad should be on top (always).
Numbers should be on top of edit, reset all, and next buttons.

jonathanolson added a commit that referenced this issue Feb 2, 2017
@jonathanolson
Copy link
Contributor

Made the requested changes. Also the numbers were over "Hide Total" in the first screen (which seemed inconsistent), so I moved that behind the numbers also.

Can you review?

@amanda-phet
Copy link
Contributor

Looks good on the first two screens, but to be consistent the paper numbers should be layered over the text numbers and next button on the game screen.

@jonathanolson
Copy link
Contributor

Sorry about that, definitely forgot about the formula on the game screen. Should be fixed.

@amanda-phet
Copy link
Contributor

It is working for the formula, but still not the next button.

screen shot 2017-02-03 at 12 11 57 pm
screen shot 2017-02-03 at 12 12 03 pm

I think we decided it would layer over any button (edit, reset all, and next).

@jonathanolson
Copy link
Contributor

Ok, should be fixed.

@jonathanolson jonathanolson removed their assignment Feb 3, 2017
@amanda-phet
Copy link
Contributor

Looks great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants