Set interceptOffset to 0, #92

phetsims · Dec 20, 2024 · 9200659 · 9200659
1 parent 0ef7b62
commit 9200659
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/js/least-squares-regression/model/Graph.ts b/js/least-squares-regression/model/Graph.ts
@@ -49,7 +49,7 @@ export default class Graph {
   // Factors for slope and intercept conversions
   public slopeFactor!: number;
   public interceptFactor!: number;
-  public interceptOffset!: number;
+  public readonly interceptOffset = 0;
 
   // Statistical fields
   private averageOfSumOfSquaresXX!: number;
@@ -128,7 +128,6 @@ export default class Graph {
   public setGraphDomain( xRange: Range, yRange: Range ): void {
     this.slopeFactor = ( yRange.max - yRange.min ) / ( xRange.max - xRange.min ) / ( this.bounds.height / this.bounds.width );
     this.interceptFactor = ( yRange.max - yRange.min ) / this.bounds.height;
-    this.interceptOffset = ( yRange.min );
   }
 
   /**

diff --git a/js/least-squares-regression/model/LeastSquaresRegressionModel.ts b/js/least-squares-regression/model/LeastSquaresRegressionModel.ts
@@ -115,7 +115,6 @@ export default class LeastSquaresRegressionModel {
       this.graph.setGraphDomain( selectedDataSet.xRange, selectedDataSet.yRange );
 
       // Populate the dataPoints array
-
       if ( selectedDataSet === DataSet.CUSTOM ) {
 
         // use the savedCustomDataPoints to populate the dataPoints array

diff --git a/js/least-squares-regression/view/GraphNode.ts b/js/least-squares-regression/view/GraphNode.ts
@@ -37,8 +37,7 @@ export default class GraphNode extends Node {
     const myLineBoundaryPoints = graph.getBoundaryPoints( graph.slope( graph.angleProperty.value ), graph.interceptProperty.value );
     this.myLine = new Line(
       modelViewTransform.modelToViewPosition( myLineBoundaryPoints.point1 ),
-      modelViewTransform.modelToViewPosition( myLineBoundaryPoints.point2 ),
-      {
+      modelViewTransform.modelToViewPosition( myLineBoundaryPoints.point2 ), {
         stroke: LeastSquaresRegressionConstants.MY_LINE_COLOR.BASE_COLOR,
         lineWidth: LeastSquaresRegressionConstants.LINE_WIDTH
       } );

diff --git a/js/least-squares-regression/view/LeastSquaresRegressionScreenView.ts b/js/least-squares-regression/view/LeastSquaresRegressionScreenView.ts
@@ -94,7 +94,7 @@ export default class LeastSquaresRegressionScreenView extends ScreenView {
       resize: false
     }, panelOptions ) );
 
-    // Create the "My Line" Control Panel (located to the left of the graph)
+    // Create the "My Line" Control Panel (located to the right of the graph)
     const myLineControlPanel = new MyLineControlPanel( model.graph, model.dataPointsAddedEmitter, panelOptions );
 
     // Create the Graph Node which is responsible for 'My Line', 'Best Fit Line' and the Residuals representation