Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import kite files from imports.js #96

Closed
zepumph opened this issue Mar 4, 2022 · 2 comments
Closed

Import kite files from imports.js #96

zepumph opened this issue Mar 4, 2022 · 2 comments
Assignees
@jonathanolson
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Mar 4, 2022

I added a lint rule to mimic the scenery one about importing from imports, instead of directly, and then I found myself needing to change thousands of files. Commits coming up! Tagging @jonathanolson

Lint rule added in phetsims/chipper@1e6e531.
@zepumph zepumph self-assigned this Mar 4, 2022
zepumph added a commit to phetsims/fluid-pressure-and-flow that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
301fe1e
zepumph added a commit to phetsims/counting-common that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
9d19940
zepumph added a commit to phetsims/graphing-lines that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
60a5d54
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
2a6de01
zepumph added a commit to phetsims/estimation that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
f5781f9
zepumph added a commit to phetsims/bamboo that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
ef75c9e
zepumph added a commit to phetsims/color-vision that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
0c33a4d
zepumph added a commit to phetsims/gravity-and-orbits that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
aad1d63
zepumph added a commit to phetsims/ohms-law that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
9a7233d
zepumph added a commit to phetsims/center-and-variability that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
5ad48ee
zepumph added a commit to phetsims/curve-fitting that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
8bce9f7
zepumph added a commit to phetsims/function-builder that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
8f85527
zepumph added a commit to phetsims/area-builder that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
bd522bc
zepumph added a commit to phetsims/plinko-probability that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
3b73f07
zepumph added a commit to phetsims/vector-addition that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
d94962d
zepumph added a commit to phetsims/collision-lab that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
82a7a6f
zepumph added a commit to phetsims/build-a-molecule that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
173f699
zepumph added a commit to phetsims/ph-scale that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
2f14464
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
eeaa702
zepumph added a commit to phetsims/equality-explorer that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
8d9238d
zepumph added a commit to phetsims/fractions-common that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
73c8198
zepumph added a commit to phetsims/geometric-optics that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
be961c1
zepumph added a commit to phetsims/rutherford-scattering that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
8a1d663
zepumph added a commit to phetsims/energy-skate-park that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
3fba31f
zepumph added a commit to phetsims/area-model-common that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
9f6aabe
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
6cc3670
zepumph added a commit to phetsims/balancing-act that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
4e49adb
zepumph added a commit to phetsims/molarity that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
6f29bcb
zepumph added a commit to phetsims/phetcommon that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
d74de98
zepumph added a commit to phetsims/griddle that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
dc9d79f
zepumph added a commit to phetsims/xray-diffraction that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
c818208
zepumph added a commit to phetsims/calculus-grapher that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
056654f
zepumph added a commit to phetsims/twixt that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
7f12eb2
zepumph added a commit to phetsims/number-line-operations that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
01a6d26
zepumph added a commit to phetsims/number-line-common that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
e7c60bd
zepumph added a commit to phetsims/unit-rates that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
c262a25
zepumph added a commit to phetsims/isotopes-and-atomic-mass that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
18d5f8e
zepumph added a commit to phetsims/molecule-shapes that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
d5596ba
zepumph added a commit to phetsims/number-line-integers that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
71bc2ea
zepumph added a commit to phetsims/forces-and-motion-basics that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
6ae1101
zepumph added a commit to phetsims/pendulum-lab that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
32bc51a
zepumph added a commit to phetsims/wave-on-a-string that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
6c966e4
zepumph added a commit to phetsims/beers-law-lab that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
af8ee4f
zepumph added a commit to phetsims/scenery-phet that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
40610ea
zepumph added a commit to phetsims/neuron that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
abbcb43
zepumph added a commit to phetsims/faradays-law that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
4a5a88d
zepumph added a commit to phetsims/scenery that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
39a6f77
zepumph added a commit to phetsims/sherpa that referenced this issue Mar 4, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
11a029e
@zepumph zepumph assigned jonathanolson and unassigned zepumph Mar 4, 2022
@zepumph
Copy link
Member Author

zepumph commented Mar 4, 2022

@jonathanolson, let me know if I should have done anything different, sorry I sorta fell into doing this work because I committed and pushed the lint rule too quickly. Feel free to close.

samreid pushed a commit to phetsims/scenery-phet that referenced this issue May 16, 2022
@zepumph
import kite files from imports.ts, phetsims/kite#96
1d82f84
marlitas pushed a commit to phetsims/scenery-phet that referenced this issue Jun 22, 2022
@zepumph @marlitas
import kite files from imports.ts, phetsims/kite#96
68787ef
marlitas pushed a commit to phetsims/sun that referenced this issue Jun 28, 2022
@zepumph @marlitas
import kite files from imports.ts, phetsims/kite#96
06d14a5
@jonathanolson
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @zepumph