We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noticed by @chrisklus in NavigationBarSoundToggleButton. To reproduce, in kite's playground or:
var NODE_HEIGHT = 22.0; var NODE_WIDTH = NODE_HEIGHT * 1.13; // constants for drawing speaker var SPEAKER_HEIGHT = NODE_HEIGHT * 0.77; var SPEAKER_WIDTH = SPEAKER_HEIGHT * 0.58; var SPEAKER_BACK_WIDTH = SPEAKER_WIDTH * 0.46; var SPEAKER_BACK_HEIGHT = SPEAKER_HEIGHT * 0.35; var SPEAKER_BACK_Y_SPACE = ( SPEAKER_HEIGHT - SPEAKER_BACK_HEIGHT ) / 2.0; var CORNER_RADIUS = 1.0; window.shape = new kite.Shape() .moveTo( SPEAKER_WIDTH, 0 ) .lineTo( SPEAKER_BACK_WIDTH, SPEAKER_BACK_Y_SPACE ) .lineTo( CORNER_RADIUS, SPEAKER_BACK_Y_SPACE) .arc( CORNER_RADIUS, SPEAKER_BACK_Y_SPACE + CORNER_RADIUS, CORNER_RADIUS, Math.PI * 1.5, Math.PI, true ) .lineToRelative( 0, SPEAKER_BACK_HEIGHT - ( 2 * CORNER_RADIUS ) ) .arc( CORNER_RADIUS, SPEAKER_BACK_Y_SPACE + SPEAKER_BACK_HEIGHT - CORNER_RADIUS, CORNER_RADIUS, Math.PI, Math.PI * 0.5, true ) .lineToRelative( SPEAKER_BACK_WIDTH - CORNER_RADIUS, 0 ) .lineTo( SPEAKER_WIDTH, SPEAKER_HEIGHT ) .lineTo( SPEAKER_WIDTH, 0 ) .close(); window.strokedShape = shape.getStrokedShape( new kite.LineStyles( { lineWidth: 1.5, lineJoin: 'round' } ) );
Fails out with an assertion.
The text was updated successfully, but these errors were encountered:
Adding stroke failure test case, see #73
96313ae
Bugfix for #73, don't draw very small line joins (that may, due to ro…
380cef5
…unding error, be interpreted as a full circle)
Thanks much @jonathanolson, closing.
Sorry, something went wrong.
jonathanolson
No branches or pull requests
Noticed by @chrisklus in NavigationBarSoundToggleButton. To reproduce, in kite's playground or:
Fails out with an assertion.
The text was updated successfully, but these errors were encountered: