-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locales are not presented in alphabetical order. #911
Comments
In design meeting with @jessegreenberg @amanda-phet @catherinecarter and @samreid: We considered three different ways of sorting: by locale code (current), by english name, and by localized name. We decided that sorting by localizedName made the most sense because it seemed the least biased towards devs and the english language. @samreid also asked ChatGPT and it said that sorting by localized name makes sense because sort functions use unicode placement after alphabetical, so this should be close to the universal way of sorting them. |
@samreid can you paste in the reference for why this is a reasonable sort? |
I asked:
ChatGPT replied:
and provided a code example of how to implement it. |
Thanks for committing 53c86e0 @chrisklus! Are there any next steps for this issue? Do we need any other tests to make sure it is OK to sort |
RE: 53c86e0 This changed the PhET-iO API and required stable API validation. Now the localeProperty validValues is a different order. |
Signed-off-by: Michael Kauzmann <[email protected]>
On the Localization tab of the Preferences dialog, the locales are not in alphabetical order. See screenshot below. It looks like they are ordered by locale code (which is not displayed) instead of by Locale.name or Locale.localizedName. It's not clear which of those should determine the ordering, but ordering them by locale code seems buggy.
The text was updated successfully, but these errors were encountered: