Fix ?allowLinks behavior

[kathy-phet]

There are a few places where links / opportunities for students to navigate away from the simulation are still available when
?allowLinks=false

Specifically, these links are still active:

PhETmenu--> PhET Website ...
PhETmenu--> Report a Problem ...

We need a solution for this when allowLinks=false.

Options off the top of my head:

hide these options in the PhETmenu
disable these options in the PhETmenu
others???

[jonathanolson]

Also, any usage of openPopup should be checked (perhaps openPopup could check to see if the query parameter is provided?)

[kathy-phet]

Original issue: #592

[kathy-phet]

@zepumph - Can you review JO's fix to allowLinks? You actually recognized this need previously in the original issue - in this comment #592 (comment), but I think you were on vacation and then the thought got lost in the final review and sign off on that issue.

Behavior currently doesn't hide the option (e.g. PhET Website ...) will be visible, but no action is taken when you click on it. Nothing happens. @arouinfar and I felt this was fine behavior for this purpose. If you are a PhET-iO client, you can do something more sophisticated and hide the option or something, but for the PhET brand sims, we just want to prevent students from clicking their way away from the simulation.

@jonathanolson - I think you were also going to review and make sure this captured all of the cases that you needed to capture for redirects.

[kathy-phet]

@jonathanolson - also, this is a candidate for a maintenance release to PhET brand, once we are sure we have fixed all cases and are happy with the PhET brand behavior.

[zepumph]

Adding behavior for openPopup makes sense, but it doesn't capture the spirit of converting query parameters to behavior that is covered/duplicated by the PhET-iO API so that it can be mutated in PhET-iO and thus supported in the standard wrapper. To do that, this would need to run off of a Property, which is kinda a no-no in phet-core.

UPDATE: Noting that this issue is in part coming out of https://github.com/phetsims/phet-io/issues/1871 where we also want to have the PhET-iO support to control this query parameter.

[zepumph]

@jonathanolson and I discussed this, and in order to have allowLinks running from a Property, we are going to move openPopup to sun, so that it can depend on axon Property.

[zepumph]

Steps for this issue:

• Have ?allowLinks set the initialValue of a PhET-iO instrumented Property, that is customizable in studio. This shouldn't be in joist/ because we still want to be able to use the Property in openPopup
• Convert usages of the allowLinks query parameter to instead dynamically adjust behavior based on the state of the Property
• Move openPopup to a place where it can use the Property. @jonathanolson and I were ok with sun/, but were open to other ideas.

Assigning to whoever gets to it first.

[zepumph]

@samreid, @arouinfar, @kathy-phet and I discussed this a bit more, and we have a new recommendation.

• We want to move openPopup to scenery, and create the allowLinksProperty singleton in scenery.

new BooleanProperty( phet.chipper.queryParameters.allowLinks, {
  tandem: Tandem.ROOT.GENERAL_MODEL.createTandem( 'allowLinksProperty' )
} );

@kathy-phet asked us to also assign @jonathanolson to this issue.

@jonathanolson, please make sure to move the git history of openPopup. Please don't use the shell script because openPopup has been renamed to ts. Instead use copy-history-to-different-repo.js.

[jonathanolson]

Maintenance complete, closing.