-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vibrationManager from Sim. #794
Comments
In duplicate #793, @jessegreenberg said:
|
I bailed on Sim.js conversion to .ts in #795, so Sim is still in JavaScript for the time being. @jessegreenberg over to you. You might want to remove vibrationManager from Sim.js before someone else spends time porting those bits. |
tappi/vibrationManager has been removed from Sim.js, closing. |
While porting Sim.js to Sim.ts, I ran into this field:
After converting to .ts, "tappi doesn't have to become a dependency for all sims yet" is not longer true. A the very least, tappi would need to be added to joist/tsconfig.json. It might also need to be added to build.json.
I asked @jessegreenberg about this on Slack, and he said:
So vibrationManager is going to be removed from Sim.ts. Since I'm partway through convertion, I'm just going to add
// @ts-ignore
for an vibrationManager code. Then I'll assign to @jessegreenberg for cleanup.The text was updated successfully, but these errors were encountered: