Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vibrationManager from Sim. #794

Closed
pixelzoom opened this issue Mar 14, 2022 · 3 comments
Closed

Remove vibrationManager from Sim. #794

pixelzoom opened this issue Mar 14, 2022 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

While porting Sim.js to Sim.ts, I ran into this field:

      // {VibrationManager|null} - Responsible for managing vibration feedback for a sim. Experimental, and
      // not used frequently. The vibrationManager instance is passed through options so that tappi doesn't have to
      // become a dependency for all sims yet. If this gets more use, this will likely change.
      vibrationManager: null,

After converting to .ts, "tappi doesn't have to become a dependency for all sims yet" is not longer true. A the very least, tappi would need to be added to joist/tsconfig.json. It might also need to be added to build.json.

I asked @jessegreenberg about this on Slack, and he said:

I think usages of vibrationManager can be removed from Sim now. There are no plans to continue with that right now. I can remove the usage from john-travoltage.

So vibrationManager is going to be removed from Sim.ts. Since I'm partway through convertion, I'm just going to add // @ts-ignore for an vibrationManager code. Then I'll assign to @jessegreenberg for cleanup.

@pixelzoom
Copy link
Contributor Author

In duplicate #793, @jessegreenberg said:

There are no plans in the next year or more to use Web based vibration. The only usage is in john-travoltage. We should remove it from both john-travoltage and Sim.js at this time. This came up as Sim.js is being converted to TypeScript. VibrationManager was only optionally included so that tappi didn't need to be a dependency for all sims, but strong typing would change that.

On hold until Sim TypeScript conversion is complete and changes can be made to Sim.ts.

@pixelzoom
Copy link
Contributor Author

I bailed on Sim.js conversion to .ts in #795, so Sim is still in JavaScript for the time being.

@jessegreenberg over to you. You might want to remove vibrationManager from Sim.js before someone else spends time porting those bits.

@jessegreenberg
Copy link
Contributor

tappi/vibrationManager has been removed from Sim.js, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants